Re: [PATCH] perf buildid: fix off-by-one in write_buildid()
From: Arnaldo Carvalho de Melo
Date: Wed Apr 20 2016 - 09:23:14 EST
Em Wed, Apr 20, 2016 at 03:36:22PM +0300, Adrian Hunter escreveu:
> On 19/04/16 16:40, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Apr 19, 2016 at 11:17:27AM +0300, Andrey Ryabinin escreveu:
> >> write_buildid() increments 'name_len' with intention to take into account
> >> trailing zero byte. However, 'name_len' was already incremented in
> >> machine__write_buildid_table() before.
> >> So this leads to out-of-bounds read in do_write():
> >
> > Adrian, can you please take a look at the db-export improvements made in
> > this series? It'd be good to have your ack for those,
>
> You mean the patches from Chris Phlipot - yes I'll look at them.
Yeah, thanks,
- Arnaldo