Re: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup
From: Javier Martinez Canillas
Date: Wed Apr 20 2016 - 10:00:09 EST
Hello Krzysztof,
On 04/20/2016 05:24 AM, Krzysztof Kozlowski wrote:
> Cleanup the weird function-level comments and remove obvious
> documentatoin for probe/remove.
>
s/documentatoin/documentation
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
I wonder if instead we should change to kernel-doc formatted documentation.
All the functions are static so kernel-doc is not really required but still
Documentation/kernel-doc-nano-HOWTO.txt says that is suggested for source
code layout consistency.
But I agree that's either kernel-doc format or minimal as your patch does:
Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America