Re: [PATCH 2/2] dmaengine: vdma: Add clock support

[Moritz Fischer]

Hi,

thanks for looking into this.

On Wed, Apr 20, 2016 at 12:20 AM, Kedareswara rao Appana
<appana.durga.rao@xxxxxxxxxx> wrote:

> +static int xdma_clk_init(struct xilinx_dma_device *xdev, bool enable)
> +{
> +       int i = 0, ret;
> +
> +       for (i = 0; i < xdev->numclks; i++) {
> +               if (enable) {
> +                       ret = clk_prepare_enable(xdev->clks[i]);
> +                       if (ret) {
> +                               dev_err(xdev->dev,
> +                                       "failed to enable the axidma clock\n");
> +                               return ret;

What happens to the ones you already turned on, if say the third fails?

Cheers,

Moritz