Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver

[Eduardo Valentin]

Laxman,

On Tue, Apr 19, 2016 at 12:52:01PM +0530, Laxman Dewangan wrote:
> In some of platform, thermal sensors like NCT thermistors are
> connected to the one of ADC channel. The temperature is read by
> reading the voltage across the sensor resistance via ADC. Lookup
> table for ADC read value to temperature is referred to get
> temperature. ADC is read via IIO framework.
> 
> Add support for thermal sensor driver which read the voltage across
> sensor resistance from ADC through IIO framework.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>

I really like this driver, as I mentioned  before. Just one comment
though.

> 
> +
> +	gti->tz_dev = thermal_zone_of_sensor_register(&pdev->dev, 0,
> +						      gti, &gadc_thermal_ops);

Why not using the devm_ version you introduced?

Any particular reason?