Re: [PATCH v11 0/3] printk: Make printk() completely async
From: Joe Perches
Date: Wed Apr 20 2016 - 22:17:25 EST
On Thu, 2016-04-21 at 11:14 +0900, Sergey Senozhatsky wrote:
> On (04/15/16 22:44), Joe Perches wrote:
> [..]
> > > Sir, is there anything else you want me to improve in this patch
> > > set?
> > I'm not sir, but my preference would be to move as much of the
> > async/thread functionality as possible into a separate file.
> hm, we are talking about some 50-60 lines of code in total (seems
> that the patch set adds more comments than code), but your point
> is interesting. let's say, if there will be more opinions that it
> better land in async_printk.{c,h} files, then I'll take a look on
> it. how does it sound?
I think printk.c is pretty large, complicated and should
be broken up into several bits.
I did that once, but it's a real development timing issue
https://lkml.org/lkml/2012/10/17/41
cheers, Joe