Re: [PATCH] mm: move huge_pmd_set_accessed out of huge_memory.c

[Kirill A. Shutemov]

On Wed, Apr 20, 2016 at 02:00:11PM -0700, Shi, Yang wrote:
> Hi folks,
> 
> I didn't realize pmd_* functions are protected by
> CONFIG_TRANSPARENT_HUGEPAGE on the most architectures before I made this
> change.
> 
> Before I fix all the affected architectures code, I want to check if you
> guys think this change is worth or not?
> 
> Thanks,
> Yang
> 
> On 4/20/2016 11:24 AM, Yang Shi wrote:
> >huge_pmd_set_accessed is only called by __handle_mm_fault from memory.c,
> >move the definition to memory.c and make it static like create_huge_pmd and
> >wp_huge_pmd.
> >
> >Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxx>

On pte side we have the same functionality open-coded. Should we do the
same for pmd? Or change pte side the same way?

-- 
 Kirill A. Shutemov