Re: [PATCH v1] cpufreq: rockchip: Use generic platdev driver

[Viresh Kumar]

On 21-04-16, 16:04, Finlye Xiao wrote:
> From: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx>
> 
> This patch add rockchip's compatible string to the compat list and
> remove similar code from platform code for supporting generic platdev
> driver.
> 
> Signed-off-by: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx>
> ---
>  arch/arm/mach-rockchip/rockchip.c    |  1 -
>  drivers/cpufreq/cpufreq-dt-platdev.c | 10 ++++++++++
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-rockchip/rockchip.c b/arch/arm/mach-rockchip/rockchip.c
> index 3f07cc5..beb71da 100644
> --- a/arch/arm/mach-rockchip/rockchip.c
> +++ b/arch/arm/mach-rockchip/rockchip.c
> @@ -74,7 +74,6 @@ static void __init rockchip_dt_init(void)
>  {
>  	rockchip_suspend_init();
>  	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> -	platform_device_register_simple("cpufreq-dt", 0, NULL, 0);
>  }
>  
>  static const char * const rockchip_board_dt_compat[] = {
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index f2ae7ad..2128767 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -21,6 +21,16 @@ static const struct of_device_id machines[] = {
>  	{ .compatible = "samsung,exynos5420", },
>  	{ .compatible = "samsung,exynos5800", },
>  #endif

Please enter a blank line here.

> +	{ .compatible = "rockchip,rk2928", },
> +	{ .compatible = "rockchip,rk3036", },
> +	{ .compatible = "rockchip,rk3066a", },
> +	{ .compatible = "rockchip,rk3066b", },
> +	{ .compatible = "rockchip,rk3188", },
> +	{ .compatible = "rockchip,rk3228", },
> +	{ .compatible = "rockchip,rk3288", },
> +	{ .compatible = "rockchip,rk3366", },
> +	{ .compatible = "rockchip,rk3368", },
> +	{ .compatible = "rockchip,rk3399", },
>  };
>  
>  static int __init cpufreq_dt_platdev_init(void)

So you won just by few minutes, I have sent an almost similar patch
just now. Anyway, you sent it first, that's all..

Please resend after the blank line.

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

-- 
viresh