Re: [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol

[Borislav Petkov]

On Thu, Apr 21, 2016 at 12:09:30PM +0100, Matt Fleming wrote:
> This symbol is always set which makes it useless. Additionally we have
> a kernel command-line switch, efi=debug, which actually controls the
> printing of the memory map.
> 
> Reported-by: Robert Elliott <elliott@xxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Signed-off-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> ---
>  arch/x86/platform/efi/efi.c | 4 ----
>  1 file changed, 4 deletions(-)

Acked-by: Borislav Petkov <bp@xxxxxxx>

Btw, there's also

arch/ia64/kernel/efi.c:45:#define EFI_DEBUG     0
arch/ia64/kernel/efi.c:399:#if EFI_DEBUG
arch/ia64/kernel/efi.c:559:#if EFI_DEBUG

I'm assuming you want to put that behind "if (efi_enabled(EFI_DBG))" too...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.