Re: [PATCH 5/8] cpufreq: shmobile: Use generic platdev driver

From: Viresh Kumar
Date: Thu Apr 21 2016 - 23:21:50 EST


On 21-04-16, 15:04, Geert Uytterhoeven wrote:
> Hi Viresh,
>
> On Thu, Apr 21, 2016 at 10:43 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > @@ -29,6 +29,18 @@ static const struct of_device_id machines[] = {
> > { .compatible = "samsung,exynos5800", },
> > #endif
> >
>
> I think an #ifdef CONFIG_ARCH_RENESAS block wouldn't hurt, likewise
> for the other SoCs.
> Soon you'll have this file filled with lots of compatible values for random\
> SoCs...

This is going to be done once per boot and this shouldn't hurt. And for new
platforms we may do things differently as they are going to use opp-v2 bindings.

And, so I am not really in favor of ifdef hackery :)

--
viresh