RE: [PATCH v7] Bluetooth: hci_uart: Support firmware download for Marvell

[Amitkumar Karwar]

Hi Marcel,

> 
> > > +
> > > +static int mrvl_setup(struct hci_uart *hu) {
> > > +	struct mrvl_data *mrvl = hu->priv;
> > > +
> > > +	mrvl_init_fw_data(hu);
> > > +	set_bit(HCI_UART_DNLD_FW, &mrvl->flags);
> > > +
> > > +	return hci_uart_dnld_fw(hu);
> > > +}
> >
> > So this is clearly the wrong spot. When ->setup is called it is
> > expected that HCI is ready. You are misusing it here.
> >
> 
> Sure. We will move this to mrvl_open() where HCI is not yet initialized.

We tried moving firmware download to mrvl_open(), but it's not feasible. "hu->proto" is not yet initialized at that time. So when the data/ack is received during firmware download, we can't have Marvell specific handling. Also, I can see other vendor's (broadcomm, Intel) have done firmware download in setup handler.

I will send V8 patch shortly. Please check.

Regards,
Amitkumar