Re: [PATCH] regulator: core: Add debugfs for regulator always_on flag

From: Mark Brown
Date: Fri Apr 22 2016 - 09:57:21 EST

On Fri, Apr 22, 2016 at 02:33:02PM +0100, Richard Fitzgerald wrote:
> This patch adds a debugfs file for the always_on flag in struct regulator.
> It's useful for debugging to be able to view the state of this flag and
> as it's set by logic inside the regulator core it doesn't necessarily have
> the same value as the always_on flag in constraints.

Why not include this in the same file as the rest of the constraints?
Or why not have one file per constraint (which would be easier for

> + ret = snprintf(buf, PAGE_SIZE, "always_on: %u\n", regulator->always_on);

> + debugfs_create_file("always_on", 0444, regulator->debugfs,

It seems to be formatted as though it's going to end up in the same file
but it's a separate file so instead it's just repeating the name of the
file inside the file.

Attachment: signature.asc
Description: PGP signature