Re: [PATCH 4/6] rtc: rv3029: Removes some checks and warnings

[Alexandre Belloni]

On 23/04/2016 at 01:29:46 +0200, Alexandre Belloni wrote :
> Hi,
> 
> On 21/04/2016 at 20:24:17 +0200, Mylène Josserand wrote :
> > @@ -829,8 +829,6 @@ static void rv3029_unregister_driver(void)
> >  
> >  static int rv3049_probe(struct spi_device *spi)
> >  {
> > -	int res;
> > -	unsigned int tmp;
> 
> Well, you just introduced those variables in the previous patch.
> 

And I forgot to add that you still have a few checkpatch warnings to
remove while at it:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#129: FILE: drivers/rtc/rtc-rv3029c2.c:129:
+			    unsigned len)

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#141: FILE: drivers/rtc/rtc-rv3029c2.c:141:
+			     unsigned len)


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com