Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

From: Eric Dumazet
Date: Sun Apr 24 2016 - 17:00:25 EST


On Sun, 2016-04-24 at 15:56 -0400, Valdis.Kletnieks@xxxxxx wrote:
> On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said:
>
> > >>> + return !debug_locks ||
> > >>> + lockdep_is_held(&sk->sk_lock) ||
>
> > Issue here is that once lockdep detected a problem (not necessarily in
> > net/ tree btw), your helper always 'detect' a problem, since lockdep
> > automatically disables itself.
>
> "D'Oh!" -- H. Simpson
>
> I thought this patch looked suspect, but couldn't put my finger on it. The
> reason why I got like 41,000 of them is because I built a kernel that has
> lockdep enabled, but I have an out-of-tree module that doesn't init something,
> so I get this:
>
> [ 48.898156] INFO: trying to register non-static key.
> [ 48.898157] the code is fine but needs lockdep annotation.
> [ 48.898157] turning off the locking correctness validator.
>
> After which point, even with this patch, every time through it's still going to
> explode.

Which patch are you talking about ?