RE: [PATCH 1/6] bus: Add shared MDIO bus framework

[Pramod Kumar]

Hi David,

Thanks for providing input over the patch.  Will address the comment as
described below.

> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: 24 April 2016 23:48
> To: pramod.kumar@xxxxxxxxxxxx
> Cc: robh+dt@xxxxxxxxxx; catalin.marinas@xxxxxxx; will.deacon@xxxxxxx;
> yamada.masahiro@xxxxxxxxxxxxx; wens@xxxxxxxx; bcm-kernel-feedback-
> list@xxxxxxxxxxxx; pawel.moll@xxxxxxx; mark.rutland@xxxxxxx;
> arnd@xxxxxxxx; suzuki.poulose@xxxxxxx; punit.agrawal@xxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; anup.patel@xxxxxxxxxxxx
> Subject: Re: [PATCH 1/6] bus: Add shared MDIO bus framework
>
> From: Pramod Kumar <pramod.kumar@xxxxxxxxxxxx>
> Date: Thu, 21 Apr 2016 14:48:38 +0530
>
> > +struct shared_mdio_master *shared_mdio_alloc_master(struct device
> *parent,
> > +						    struct device_node
*node)
> > +{
> > +	int ret = 0;
> > +	struct shared_mdio_master *master;
>
> Always order local variable declarations in reverse christmas tree
(longest to
> shortest line) order.
>

Sure. Next patch will address this.

> > +static int shared_mdio_driver_probe(struct device *dev) {
> > +	int rc;
> > +	struct shared_mdio_master *master = to_shared_mdio_master(dev);
> > +	struct shared_mdio_driver *drv =
to_shared_mdio_driver(dev->driver);
>
> Likewise.

Sure.

> Please audit your entire submission for this issue.

Sure. I'll audit the entire patch set for above issue.

Regards,
Pramod