Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

From: Boris Ostrovsky
Date: Mon Apr 25 2016 - 09:55:21 EST


On 04/25/2016 09:47 AM, Borislav Petkov wrote:
On Mon, Apr 25, 2016 at 09:21:27AM -0400, Boris Ostrovsky wrote:
I was following Documentation/x86/boot.txt (plus comments in code preceding
those two routines) which I considered to be the API.

We are supposed to come to startup_32 with paging off and %esi pointing to
boot_params. For 64-bit paging is on, %rsi points to zero-page.
So the entry points which are ABI and the ones I believe you're talking
about are in arch/x86/boot/compressed/head_64.S. But you have all this
stuff laid out in arch/x86/xen/ and I don't see you using the entry
points in boot/compressed/. It looks more to me that you're using the
ones in arch/x86/kernel/head_{32,64}.S after decompression.

Yes, those. We don't do anything in arch/x86/boot/compressed, hypervisor loads vmlinuX at entry point specified by XEN_ELFNOTE_PHYS32_ENTRY (which is hvmlite_start_xen).


-boris