Re: [PATCH v1 4/5] perf: Introduce address range filtering

[Alexander Shishkin]

Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:

> On Fri, Apr 22, 2016 at 07:19:11PM +0300, Alexander Shishkin wrote:
>> @@ -393,12 +405,64 @@ struct pmu {
>>  	void (*free_aux)		(void *aux); /* optional */
>>  
>>  	/*
>> +	 * Validate address range filters: make sure hw supports the
>> +	 * requested configuration and number of filters; return 0 if the
>> +	 * supplied filters are valid, -errno otherwise.
>> +	 */
>> +	int (*addr_filters_validate)	(struct list_head *filters);
>> +					/* optional */
>> +
>> +	/*
>> +	 * Synchronize address range filter configuration:
>> +	 * translate hw-agnostic filter into hardware configuration in
>> +	 * event::hw::addr_filters.
>> +	 */
>> +	void (*addr_filters_sync)	(struct perf_event *event);
>> +					/* optional */
>
> So these two are not serialized the 'normal' way right? Does that want
> more comment?

Yes, will see to it.

Thanks,
--
Alex