Re: [patch] skd: disable broken discard support

From: Jeff Moyer
Date: Mon Apr 25 2016 - 15:33:16 EST


Jens Axboe <axboe@xxxxxxxxx> writes:

> On 04/25/2016 01:19 PM, Jeff Moyer wrote:
>> Simply creating a file system on an skd device, followed by mount and
>> fstrim will result in errors in the logs, and even a BUG(). Let's
>> disable it. As far as I can tell, it hasn't worked right since it was
>> merged. Note that I've only disabled the reporting here, I haven't
>> removed the implementation bits in the code. Jens, let me know if you
>> want me to yank it out completely.
>
> I agree with yanking it, but let's remove all the support bits as well
> so we don't have dead code around. If someone wants to resurrect it,
> it's all there in the git history anyway.

Sounds good.

Thanks,
Jeff