Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface

From: Lu Baolu
Date: Mon Apr 25 2016 - 20:43:50 EST


Hi,

On 04/26/2016 07:51 AM, Chanwoo Choi wrote:
> Hi Lu,
>
> On 2016ë 04ì 25ì 17:04, Lu Baolu wrote:
>> GPIO resource could be retrieved through APCI as well.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
>> Reviewed-by: Felipe Balbi <balbi@xxxxxxxxxx>
>> Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>> ---
>> drivers/extcon/extcon-usb-gpio.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
>> index af9c8b0..472c431 100644
>> --- a/drivers/extcon/extcon-usb-gpio.c
>> +++ b/drivers/extcon/extcon-usb-gpio.c
>> @@ -26,6 +26,7 @@
>> #include <linux/platform_device.h>
>> #include <linux/slab.h>
>> #include <linux/workqueue.h>
>> +#include <linux/acpi.h>
>>
>> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */
>>
>> @@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
>> struct usb_extcon_info *info;
>> int ret;
>>
>> - if (!np)
>> + if (!np && !ACPI_HANDLE(dev))
>> return -EINVAL;
>>
>> info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
>>
> Applied it.
>
> Thanks,
> Chanwoo Choi
>

Thank you.

Best regards,
Baolu

>