Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

[Lu Baolu]

Hi Mark,

On 04/26/2016 01:30 AM, Mark Brown wrote:
> On Mon, Apr 25, 2016 at 04:04:50PM +0800, Lu Baolu wrote:
>
>> +	ret = device_property_read_string(dev, "gpio-name", &gpio_name);
>> +	if (!ret) {
>> +		gpiod = gpiod_get(dev, gpio_name, GPIOD_ASIS);
>> +		if (!IS_ERR(gpiod)) {
> This doesn't look like it's a standard ACPI binding for GPIOs, why are
> we using a property to get the GPIO noame?

The GPIO name might be different in different use cases. For my case,
it is "vbus_en", but other cases should use the different name.

On ACPI compatible platforms, GPIO resources are reported via ACPI
tables and (devm_)gpiod_get() hides the APCI complexity and returns
the gpiod according to "gpio_name".

Best regards,
Lu Baolu