Re: [PATCH] ARM: cache-uniphier: activate ways for secondary CPUs

From: Arnd Bergmann
Date: Tue Apr 26 2016 - 03:52:59 EST


On Tuesday 26 April 2016 09:55:35 Masahiro Yamada wrote:
> Hi Arnd,
>
> 2016-04-26 7:13 GMT+09:00 Arnd Bergmann <arnd@xxxxxxxx>:
> > On Friday 15 April 2016 16:05:46 Masahiro Yamada wrote:
> >> This outer cache allows to control active ways independently for
> >> each CPU, but currently nothing is done for secondary CPUs. In
> >> other words, all the ways are locked for secondary CPUs by default.
> >> This commit fixes it to fully bring out the performance of this
> >> outer cache.
> >>
> >> There would be two possible ways to achieve this:
> >>
> >> [1] Each CPU initializes active ways for itself. This can be done
> >> via the SSCLPDAWCR register. This is a banked register, so each
> >> CPU sees a different instance of the register.
> >>
> >> [2] The master CPU initializes active ways for all the CPUs. This
> >> is available via SSCDAWCARMR(N) registers. They are mapped at
> >> the address SSCDAWCARMR + 4 * N, where N is the CPU number.
> >>
> >> Currently, the outer cache frame work does not support a per-CPU
> >> init callback. So this commit adopts [2]; the master CPU iterates
> >> over possible CPUs setting up SSCDAWCARMR(N) registers.
> >>
> >> Unfortunately, the register offsets of SSCDAWCARMR(N) are different
> >> by SoC. We can live with it by checking the version register.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> >>
> >
> > Applied to next/soc, thanks!
> >
> > I'm a little lost with the patches you send, could you check that
> > I have applied all the ones you sent for 4.7 so far?
> >
> > Arnd
>
>
> Was this one really applied, or not yet?
>
> My intention was to send this one just for review,
> because outer-cache things are generally in Russell's field.
>
> If you have already applied it, I should drop it
> from Russell's patch tracker.
> (Sorry, I should have mentioned it.)
>
> Please let me know the status.

Sorry, my mistake, I accidentally sent out my mail early and
then did not put it into arm-soc in the end.

It's not in arm-soc and it should go through Russell's patch tracker.

Arnd