Re: [PATCH v2 0/3] pinctrl/broxton: enable platform device in the absent of ACPI enumeration

From: Andy Shevchenko
Date: Tue Apr 26 2016 - 07:58:29 EST


On Tue, 2016-04-26 at 14:09 +0800, Tan Jui Nee wrote:
> Hi,
> The patches are to cater the need for non-ACPI system whereby
> a platform device has to be created in order to bind with
> Apollo Lake Pinctrl GPIO platform driver.
>
> The MMIO BAR is accessed over the Primary to Sideband bridge
> (P2SB). Since the BIOS prevents the P2SB device from being
> enumerated by the PCI subsystem, so we need to hide/unhide P2SB
> to lookup the P2SB BAR and pass the PCI BAR address to the gpio
> platform driver.
>
> All these three patches have dependencies on each other.
>

Lee, Linus, I'm fine with the series, though I doubt which solution is
better to have the original driver independent as much as possible from
p2sb.

> Changes from V1:
> - Add new config option CONFIG_X86_INTEL_NON_ACPI and "select
> PINCTRL"
> ÂÂto fix kbuildbot error
>
> Andy Shevchenko (1):
> Â x86/platform/p2sb: New Primary to Sideband bridge support driver for
> ÂÂÂÂIntel SOC's
>
> Tan Jui Nee (2):
> Â pinctrl/broxton: enable platform device in the absent of ACPI
> ÂÂÂÂenumeration
> Â mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in
> ÂÂÂÂnon-ACPI system
>
> Âarch/x86/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ14 ++++
> Âarch/x86/include/asm/p2sb.hÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ27 +++++++
> Âarch/x86/platform/intel/MakefileÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> Âarch/x86/platform/intel/p2sb.cÂÂÂÂÂÂÂÂÂÂ|ÂÂ99
> ++++++++++++++++++++++++
> Âdrivers/mfd/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ3 +-
> Âdrivers/mfd/lpc_ich.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 128
> ++++++++++++++++++++++++++++++++
> Âdrivers/pinctrl/intel/pinctrl-broxton.c |ÂÂ43 ++++++++---
> Â7 files changed, 302 insertions(+), 13 deletions(-)
> Âcreate mode 100644 arch/x86/include/asm/p2sb.h
> Âcreate mode 100644 arch/x86/platform/intel/p2sb.c
>

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy