Re: [PATCH 1/3] mfd: add Cypress FM33256B Processor Companion driver
From: Jeppe Ledet-Pedersen
Date: Tue Apr 26 2016 - 10:44:13 EST
On 22/04/16 21:32, Rob Herring wrote:
> On Wed, Apr 20, 2016 at 01:07:49PM +0200, Jeppe Ledet-Pedersen wrote:
[snip]
>> +
>> +The MFD exposes two subdevices:
>> +- The FRAM: "cypress,fm33256b-fram"
>> +- The RTC: "cypress,fm33256b-rtc"
>> +
>> +Example:
>> +
>> +spi1: spi@f800800 {
>> + status = "okay";
>> + cs-gpios = <&pioC 25 0>;
>> +
>> + fm33256b@0 {
>> + compatible = "cypress,fm33256b";
>> + spi-max-frequency = <10000000>;
>> + cypress,charge-enabled;
>> + cypress,charge-fast;
>> + reg = <0>;
>> + };
>
> Where's the 2nd sub device?
Hi Rob,
Right now I just add the two sub-devices using mfd_add_devices in the
fm33256b_probe function in my MFD driver. Would it be better to check
for compatible child nodes before adding each sub-device, like it's done
in drivers/mfd/tc3589x.c?
Thanks,
-Jeppe