Re: [PATCH perf/core v4 04/19] perf: Add lsdir to read a directory

[Arnaldo Carvalho de Melo]

Em Tue, Apr 26, 2016 at 11:52:29PM +0900, Masami Hiramatsu escreveu:
> On Tue, 26 Apr 2016 11:07:42 -0300
> Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> 
> > Em Tue, Apr 26, 2016 at 10:40:20AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Tue, Apr 26, 2016 at 06:02:42PM +0900, Masami Hiramatsu escreveu:
> > > > From: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> > > > 
> > > > As a utility function, add lsdir() which reads given
> > > > directory and store entry name into a strlist.
> > > > lsdir accepts a filter function so that user can
> > > > filter out unneeded entries.
> > > > 
> > > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> > > > Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > > 
> > > Thanks, applied.
> > 
> > Had to fix it to build on some distros, like ubuntu 12.04:
> > 
> > alldeps-ubuntu-12.04: FAIL
> > util/util.h:228:38: error: declaration of 'dirname' shadows a global declaration [-Werror=shadow]
> > cc1: all warnings being treated as errors
> > mv: cannot stat `/tmp/build/perf/util/.db-export.o.tmp': No such file or directory
> > make[3]: *** [/tmp/build/perf/util/db-export.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > make[2]: *** [util] Error 2
> > make[2]: *** [ui] Error 2
> > make[1]: *** [/tmp/build/perf/libperf-in.o] Error 
> > make: *** [install-bin] Error 2
> > 
> 
> Hmm, I didn't know that the dummy argument can shadow a global declaration.
> I might be better to rename "dirname" to "dir_name".

I used 'name', its a short function and the name (lsdir) should indicate
that name is indeed the directory name.

- Arnaldo