Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks

[Vinod Koul]

On Tue, Apr 26, 2016 at 08:08:16AM -0400, okaya@xxxxxxxxxxxxxx wrote:
> On 2016-04-25 23:30, Vinod Koul wrote:
> >On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote:
> >
> >>+static int hidma_chan_stats(struct seq_file *s, void *unused)
> >>+{
> >>+	struct hidma_chan *mchan = s->private;
> >>+	struct hidma_desc *mdesc;
> >>+	struct hidma_dev *dmadev = mchan->dmadev;
> >>+
> >>+	pm_runtime_get_sync(dmadev->ddev.dev);
> >
> >debug shouldn't power up device, why do you want to do that
> 
> 
> Clocks are turned off while the hw is idle. I canât reach hw
> registers without restoring power.

Hmm, have you thought about using regmap?

-- 
~Vinod