Re: [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3)

From: David Miller
Date: Tue Apr 26 2016 - 12:25:24 EST


From: Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>
Date: Tue, 26 Apr 2016 13:54:27 +0200

> On Tue, Apr 26, 2016 at 10:06:10AM +0200, Nicolas Dichtel wrote:
>>
>> This is the continuation (series #3) of the work done to align netlink
>> attributes when these attributes contain some 64-bit fields.
>>
>> It's the last patchset from what I've seen.
>>
>> The last user of nla_put_u64() is block/drbd. This module does not use
>> standard netlink API (see all the stuff in include/linux/genl_magic_struct.h
>> and include/linux/genl_magic_func.h). I didn't modify it because it's seems
>> hard to do it whithout testing and fully understanding the context
>
> Something like this should just work.

Unfortunately we had problems using unspec, that's why an explicit new
padding attribute is added for each netlink attribute set.