Re: [PATCH] block: partitions: efi: Always check for alternative GPT at end of drive

From: Austin S. Hemmelgarn
Date: Tue Apr 26 2016 - 15:28:24 EST


On 2016-04-26 14:10, Davidlohr Bueso wrote:
On Tue, 26 Apr 2016, Austin S. Hemmelgarn wrote:

At the absolute minimum, we should be logging (at least at a warning
level) that we had to fall back the the backup GPT. If somebody is
dealing with a disk that had a torn write to the primary GPT, that's
one thing, but this could also be caused by any number of other
problems (hardware issues, malicious intent, etc), and we need to log
that we detected corrupted data.

We already complain about corrupted primary gpt (at a warn level), and
there's also plenty of verbosity about differences between primary and
backup (see compare_gpts()), or are you referring to something else?
Ah, you're right, somehow I had missed this.