Re: [PATCH v2] localmodconfig: Fix whitespace repeat count after "tristate"

From: Steven Rostedt
Date: Tue Apr 26 2016 - 15:51:41 EST


On Tue, 26 Apr 2016 11:56:38 -0700
Benjamin Poirier <bpoirier@xxxxxxxx> wrote:

> Also recognize standalone "prompt".
>
> Before this patch we incorrectly identified some symbols as not having a
> prompt and potentially needing to be selected by something else.
>
> Note that this patch could theoretically change the resulting .config,
> causing it to have fewer symbols turned on. However, given the current set
> of Kconfig files, this situation does not occur because the symbols newly
> added to %prompts are absent from %selects.
>
> Signed-off-by: Benjamin Poirier <bpoirier@xxxxxxxx>
> ---
> scripts/kconfig/streamline_config.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index 95a6f2b..b8c7b29 100755
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -237,7 +237,7 @@ sub read_kconfig {
> }
>
> # configs without prompts must be selected
> - } elsif ($state ne "NONE" && /^\s*tristate\s\S/) {
> + } elsif ($state ne "NONE" && /^\s*(tristate\s+\S|prompt\b)/) {

I prefer not to have the "prompt" here. I'm only interested in module
configs. But the \s to \s+ is a real fix.

Can you resend?

-- Steve

> # note if the config has a prompt
> $prompts{$config} = 1;
>