RE: [PATCH 3/4] ACPI / osi: Change default _OSI(Darwin) support

From: Zheng, Lv
Date: Tue Apr 26 2016 - 22:01:48 EST


Hi,

> From: rjwysocki@xxxxxxxxx [mailto:rjwysocki@xxxxxxxxx] On Behalf Of
> Rafael J. Wysocki
> Sent: Wednesday, April 27, 2016 4:13 AM
> Subject: Re: [PATCH 3/4] ACPI / osi: Change default _OSI(Darwin) support
>
> On Tue, Apr 26, 2016 at 9:40 AM, Lv Zheng <lv.zheng@xxxxxxxxx> wrote:
> > From: Chen Yu <yu.c.chen@xxxxxxxxx>
> >
> > Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always
> > reports positive value when Apple hardware queries _OSI("Darwin"). However
> > since this implementation places the judgement in runtime, it breaks
> > acpi_osi=!Darwin and cannot return unsupported for _OSI("WinXXX") invoked
> > before invoking _OSI("Darwin").
> >
> > This patch fixes the issues by reverting the wrong support and implementing
> > the default behavior of _OSI("Darwin")/_OSI("WinXXX") on Apple hardware
> via
> > DMI matching.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=92111
> > Reported-by: Lukas Wunner <lukas@xxxxxxxxx>
> > Signed-off-by: Chen Yu <yu.c.chen@xxxxxxxxx>
> > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
>
> Why don't you add a Fixes tag pointing to the problematic commit?
[Lv Zheng]
OK, I'll help to add it and re-send an UPDATE for this patch.

Thanks
-Lv