Re: [PATCH 02/19] radix-tree: Miscellaneous fixes

[NeilBrown]

On Fri, Apr 15 2016, Matthew Wilcox wrote:

> Typos, whitespace, grammar, line length, using the correct types, etc.
>
> Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
> Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>

>  
> -static inline void root_tag_clear(struct radix_tree_root *root, unsigned int tag)
> +static inline void root_tag_clear(struct radix_tree_root *root, unsigned tag)

Changing "unsigned int" to "unsigned" - Bold.

>  {
>  	root->gfp_mask &= (__force gfp_t)~(1 << (tag + __GFP_BITS_SHIFT));
>  }
> @@ -159,7 +159,7 @@ static inline void root_tag_clear_all(struct radix_tree_root *root)
>  
>  static inline int root_tag_get(struct radix_tree_root *root, unsigned int tag)

Not doing it uniformly - Priceless.

NeilBrown

Attachment: signature.asc
Description: PGP signature