Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

[Felipe Balbi]

Hi,

Mark Brown <broonie@xxxxxxxxxx> writes:
> On Wed, Apr 27, 2016 at 08:37:20AM +0300, Felipe Balbi wrote:
>> Jisheng Zhang <jszhang@xxxxxxxxxxx> writes:
>
>> > +	vbus = devm_regulator_get(&pdev->dev, "vbus");
>
>> devm_regulator_get_optional() ??
>
> Does USB work without a VBUS?  Unless the answer is yes then I'd expect

<joke> it can, just source VBUS from a lab power supply </joke>

> this to be just a normal regulator_get().

jokes aside, this regulator is optional because not all platforms
require a SW controlled regulator, no ? Will normal regulator_get() give
us a dummy regulator in case it's not listed in DT/ACPI ?

-- 
balbi

Attachment: signature.asc
Description: PGP signature