Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control

From: Felipe Balbi
Date: Wed Apr 27 2016 - 06:41:04 EST



Hi,

Mark Brown <broonie@xxxxxxxxxx> writes:
> On Wed, Apr 27, 2016 at 01:25:27PM +0300, Felipe Balbi wrote:
>> Mark Brown <broonie@xxxxxxxxxx> writes:
>
>> > this to be just a normal regulator_get().
>
>> jokes aside, this regulator is optional because not all platforms
>> require a SW controlled regulator, no ? Will normal regulator_get() give
>> us a dummy regulator in case it's not listed in DT/ACPI ?
>
> Yes we do that, but even regulators that are not software controlled

okay, good.

> should really be described anyway since it's a much simpler rule for

okay, we'll wait until all vendors update their ACPI tables ;-)

> people to understand, it ensures that we can just scale up on systems
> where there does happen to be software control and it makes all the
> resulting code much simpler and hence less error prone if we're not
> randomly ignoring some errors.

--
balbi

Attachment: signature.asc
Description: PGP signature