Re: [PATCH] cpufreq: st: enable selective initialization based on the platform

[Sudeep Holla]

On 27/04/16 12:47, Viresh Kumar wrote:
> On 27-04-16, 12:40, Sudeep Holla wrote:
> > The sti-cpufreq does unconditional registration of the cpufreq-dt driver
> > which causes issue on an multi-platform build. For example, on Vexpress
> > TC2 platform, we get the following error on boot:
> >
> > cpu cpu0: OPP-v2 not supported
> > cpu cpu0: Not doing voltage scaling
> > cpu: dev_pm_opp_of_cpumask_add_table: couldn't find opp table
> > 	for cpu:0, -19
> > cpu cpu0: dev_pm_opp_get_max_volt_latency: Invalid regulator (-6)
> > ...
> > arm_big_little: bL_cpufreq_register: Failed registering platform driver:
> > 		vexpress-spc, err: -17
> >
> > The actual driver fails to initialise as cpufreq-dt is probed
> > successfully, which is incorrect. This issue can happen to any platform
> > not using cpufreq-dt in a multi-platform build.
> >
> > This patch adds a check to do selective initialization of the driver.
> >
> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> > Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > Cc: linux-pm@xxxxxxxxxxxxxxx
> > Fixes: ab0ea257fc58 ("cpufreq: st: Provide runtime initialised driver for ST's platforms")
> > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> > ---
> >   drivers/cpufreq/sti-cpufreq.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c
> > index a9c659f58974..5fce58712a97 100644
> > --- a/drivers/cpufreq/sti-cpufreq.c
> > +++ b/drivers/cpufreq/sti-cpufreq.c
> > @@ -259,6 +259,10 @@ static int sti_cpufreq_init(void)
> >   {
> >   	int ret;
> >
> > +	if ((!of_machine_is_compatible("st,stih407-b2120")) &&
> > +		(!of_machine_is_compatible("st,stih407")))
>
> Isn't just testing this for stih407 enough? instead of two ?

Yes that should be sufficient but it would be good if Lee confirms the
same., just played safe :)

--
Regards,
Sudeep