Re: [PATCH v2 4/5] ARM: dts: omap5: describe control for ckobuffer

[Peter Ujfalusi]

On 04/27/2016 05:10 PM, Tero Kristo wrote:
> On 27/04/16 16:10, H. Nikolaus Schaller wrote:
>>
>>> Am 27.04.2016 um 14:31 schrieb Tero Kristo <t-kristo@xxxxxx>:
>>>
>>> On 27/04/16 09:04, H. Nikolaus Schaller wrote:
>>>>
>>>>> Am 26.04.2016 um 19:27 schrieb Tony Lindgren <tony@xxxxxxxxxxx>:
>>>>>
>>>>> Tero,
>>>>>
>>>>> * H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> [160418 11:23]:
>>>>>> OMAP5 has a register to control if the ckobuffer is enabled
>>>>>> and defines the polarity. ckobuffer is required to drive a twl6040
>>>>>> with the system clock. Hence, add the pinctrl,single to the
>>>>>> OMAP5 SoC description so that omap5-board-common can
>>>>>> set up the ckobuffer as required.
>>>>>
>>>>> Is this really a mux or should it be a mux clock?
>>>>
>>>> It is a pinmux setting for the clock out buffer to choose what signal
>>>> (and polarity) is presented on the fref_xtal_clk pad.
>>>>
>>>> The register is part of the CTRL_MODULE_WKUP.
>>>> The clock signal is the xtal master clock of the whole SoC.
>>>>
>>>> Although there is a bit to choose an alternate clock, there is no
>>>> alternate in the OMAP5 silicon.
>>>>
>>>> Therefore I would say it is about padconf and not clock or clock mux
>>>> related.
>>>>
>>>> It just happens to be a clock signal which can be routed to this
>>>> pad.
>>>
>>> The two could very well be implemented as clock nodes, a mux and a gate.
>>> This would describe the hardware functionality better imo, if the
>>> assumptions made here are correct. Implementing the control as pinctrl
>>> hacks looks rather weird to me.
>>
>> Why do you consider it a "pinctrl hack"? IMHO it is not a hack, but 100%
>> proper use of pinctrl.
> 
> It is just the level of abstraction we are talking about here. If it is a
> clock we are controlling, we should rather control it as a clock (higher level
> abstraction), not a pin.

I second this. I think it is better to have a simple gate clock and handle
only CONTROL_CKOBUFFER:CKOBUFFER_CLK_EN (bit 28) only as the other bits does
not have real use.

Then we can add clk API support for this. On most OMAP4 devices the clock is
always on, so the board DTS file need to provide a dummy clock, or we can make
the high precision clock also as optional (on panda both OMAP4 and twl6040
uses the same reference clock).

-- 
Péter