Re: [PATCH V10 1/6] mfd: add device-tree binding doc for PMIC max77620/max20024

From: Lee Jones
Date: Wed Apr 27 2016 - 11:31:15 EST


On Wed, 27 Apr 2016, Thierry Reding wrote:

> On Wed, Apr 27, 2016 at 01:49:59PM +0100, Lee Jones wrote:
> > On Wed, 30 Mar 2016, Laxman Dewangan wrote:
> >
> > > The MAXIM PMIC MAX77620 and MAX20024 are power management IC
> > > which supports RTC, GPIO, DCDC/LDO regulators, interrupt,
> > > watchdog etc.
> > >
> > > Add DT binding document for the different functionality of
> > > this device.
> > >
> > > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> > > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > >
> > > ---
> > > Changes from V1:
> > > - Added units in some of properties.
> > > - Change the boolean property to tristate type and detail some of
> > > properties.
> > >
> > > Change from V2:
> > > - added unit in period related dt property.
> > >
> > > Change from V3: None
> > > - Added Rob's ack.
> > >
> > > Changes from V4:
> > > - A- Provide more details in the dt binding doc.
> > > - Take care of fps nodes.
> > > - Split the submodule's DT binding doc on respective folder.
> > > - Drop the battery charger and low battery binding and related code as
> > > it need to go on power driver.
> > >
> > > Change from V5:
> > > - None
> > >
> > > Change from V6:
> > > -start the patch title with mfd instead of DT: mfd:
> > >
> > > Change from V7:
> > > - Better describe the FPS to make more clear.
> > >
> > > Changes from V8:
> > > None
> > >
> > > Changes from V9:
> > > None
> > >
> > > Documentation/devicetree/bindings/mfd/max77620.txt | 143 +++++++++++++++++++++
> > > include/dt-bindings/mfd/max77620.h | 39 ++++++
> > > 2 files changed, 182 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/mfd/max77620.txt
> > > create mode 100644 include/dt-bindings/mfd/max77620.h
> >
> > For my own reference:
> >
> > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> Hi Lee,
>
> I'm confused now. Were you going to pick this up, or are you waiting for
> someone else to do it?

I will pick it up once I'm good with the driver.

The "For my own reference" tags are just to let me know not to waste
my time and re-review.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog