Re: [PATCH 3.16 098/217] s390/pci: enforce fmb page boundary rule

From: Ben Hutchings
Date: Wed Apr 27 2016 - 14:14:30 EST


On Wed, 2016-04-27 at 19:27 +0200, Sebastian Ott wrote:
> On Wed, 27 Apr 2016, Ben Hutchings wrote:
> >
> > 3.16.35-rc1 review patch.ÂÂIf anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
> >
> > commit 80c544ded25ac14d7cc3e555abb8ed2c2da99b84 upstream.
> >
> > The function measurement block must not cross a page boundary. Ensure
> > that by raising the alignment requirement to the smallest power of 2
> > larger than the size of the fmb.
> >
> > Fixes: d0b088531 ("s390/pci: performance statistics and debug infrastructure")
> > Signed-off-by: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > [bwh: Backported to 3.16: adjust context]
> > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> The BUILD_BUG_ON below will be triggered. This patch has a
> dependency on commit:
> 6001018ae "s390/pci: extract software counters from fmb"
> could you please fetch that one too?
[...]

Thanks, I've now done that. ÂI'm hoping to get cross-architecture build
testing for 3.16.y in place soon so I can catch this sort of thing
earlier.

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part