Re: [PATCH v3] char/rtc: replace blacklist with whitelist
From: Arnd Bergmann
Date: Wed Apr 27 2016 - 16:01:13 EST
On Wednesday 27 April 2016 21:52:48 Geert Uytterhoeven wrote:
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -279,8 +279,7 @@ if RTC_LIB=n
> >
> > config RTC
> > tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> > - depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > - && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> > + depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300
>
> Minor nit: MACH_LOONGSON64 implies MIPS, so I think you can drop the latter.
>
I listed it intentionally, to make it clearer to the reader what is
going on. Actually MIPS as a dependency by itself would also be sufficient,
because that contains
select RTC_LIB if !MACH_LOONGSON64
and RTC depends on !RTC_LIB.
Arnd