Re: [PATCH] cpufreq: governor: Change confusing struct field and variable names

From: Viresh Kumar
Date: Wed Apr 27 2016 - 22:16:41 EST


On 28-04-16, 01:19, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The name of the prev_cpu_wall field in struct cpu_dbs_info is
> confusing, because it doesn't represent wall time, but the previous
> update time as returned by get_cpu_idle_time() (that may be the
> current value of jiffies_64 in some cases, for example).
>
> Moreover, the names of some related variables in dbs_update() take
> that confusion further.
>
> Rename all of those things to make their names reflect the purpose
> more accurately. While at it, drop unnecessary parens from one of
> the updated expressions.
>
> No functional changes.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
> drivers/cpufreq/cpufreq_governor.c | 22 +++++++++++-----------
> drivers/cpufreq/cpufreq_governor.h | 2 +-
> 2 files changed, 12 insertions(+), 12 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh