Re: [PATCH 16/21] X86_64, UV: Add obtaining GAM Range Table from UV BIOS

[Ingo Molnar]

* Mike Travis <travis@xxxxxxx> wrote:

> +	if (uv_systab->revision >= UV_SYSTAB_VERSION_UV4) {
> +		iounmap(uv_systab);
> +		uv_systab = (struct uv_systab *)
> +				ioremap(efi.uv_systab, uv_systab->size);
> +		if (!uv_systab) {
> +			pr_err("UV: UVsystab: ioremap(%d) failed!\n",
> +				uv_systab->size);
> +			return;
> +		}
> +	}
> +	pr_info("UV: UVsystab: Revision:%x\n", uv_systab->revision);

So your series in general has a lot of ugly line breaks in them, which suggests 
you took checkpatch.pl output too literally. Many of the linebreaks seem 
unnecessary, such as tihs cast:.

> +		uv_systab = (struct uv_systab *)
> +				ioremap(efi.uv_systab, uv_systab->size);

as ioremap() returns void * so it ought to be fine to just leave out the type 
cast?

etc. Please review the rest of the series for such details as well.

Thanks,

	Ingo