Re: [PATCH 1/2] PM / OPP: Remove OF dependency on dev_pm_opp_of_{cpumask_,}remove_table

From: Sudeep Holla
Date: Thu Apr 28 2016 - 07:22:13 EST




On 28/04/16 12:12, Viresh Kumar wrote:
On 28-04-16, 11:25, Sudeep Holla wrote:
+ * dev_pm_opp_remove_table() - Free OPP table static entries associated with
+ * the device

Its not about static entries anymore, right? We will end up removing everything
we had in the table.


No, not yet. I have not made that change yet. I just asked that question
in patch 2. I still remove individually but wanted to know if removing
dynamic opp is any issue ?

The OPP added using dev_pm_opp_add are marked dynamic and are not
deleted by dev_pm_opp_{,cpumask_}remove_table. If it does, then
scpi_free_opp_table can be assigned that instead of what I have in patch
2/2.

Can you please update comments also in the same patch ?


Sure once you agree and I make that change ;)

--
Regards,
Sudeep