Re: [PATCH v3 2/2] dt-bindings: imx: ldb: Add ddc-i2c-bus property

[Rob Herring]

On Wed, Apr 27, 2016 at 04:23:34PM -0400, Akshay Bhat wrote:
> Document the ddc-i2c-bus property used by imx-ldb driver to read EDID
> information via I2C interface.
> 
> Signed-off-by: Akshay Bhat <akshay.bhat@xxxxxxxxxxx>
> ---
> 
> v3:
> Newly added.
> 
>  Documentation/devicetree/bindings/display/imx/ldb.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/imx/ldb.txt b/Documentation/devicetree/bindings/display/imx/ldb.txt
> index 0a175d9..a407462 100644
> --- a/Documentation/devicetree/bindings/display/imx/ldb.txt
> +++ b/Documentation/devicetree/bindings/display/imx/ldb.txt
> @@ -62,6 +62,7 @@ Required properties:
>     display-timings are used instead.
>  
>  Optional properties (required if display-timings are used):

The required part doesn't make sense if you add this, but...

> + - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing

Really, this should be part of a connector node since i2c goes from the 
i2c controller to a connector and is not part of the display controller.

>   - display-timings : A node that describes the display timings as defined in
>     Documentation/devicetree/bindings/display/display-timing.txt.
>   - fsl,data-mapping : should be "spwg" or "jeida"
> -- 
> 2.8.1
>