Re: [PATCH v7 22/24] [media] rtl2832: change the i2c gate to be mux-locked
From: Peter Rosin
Date: Fri Apr 29 2016 - 00:41:55 EST
On 2016-04-28 23:47, Wolfram Sang wrote:
> On Wed, Apr 20, 2016 at 05:18:02PM +0200, Peter Rosin wrote:
>> The root i2c adapter lock is then no longer held by the i2c mux during
>> accesses behind the i2c gate, and such accesses need to take that lock
>> just like any other ordinary i2c accesses do.
>>
>> So, declare the i2c gate mux-locked, and zap the regmap overrides
>> that makes the i2c accesses unlocked and use plain old regmap
>> accesses. This also removes the need for the regmap wrappers used by
>> rtl2832_sdr, so deconvolute the code further and provide the regmap
>> handle directly instead of the wrapper functions.
>>
>> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>
> Antti, I'd need some tag from you since this is not the i2c realm.
>
Antti sent this:
https://lkml.org/lkml/2016/4/20/828
and I added a Tested-by in v8
https://github.com/peda-r/i2c-mux/commit/c023584d34db7aacbc59f28386378131cfa970d2
but the patch was never sent as an email, only as part of a pull request for
https://github.com/peda-r/i2c-mux/commits/mux-core-and-locking-8
So, I think all is ok, or do you need more than Tested-by?
Cheers,
Peter