Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic
From: Linus Walleij
Date: Fri Apr 29 2016 - 05:17:45 EST
On Tue, Apr 19, 2016 at 4:03 PM, Ludovic Desroches
<ludovic.desroches@xxxxxxxxx> wrote:
> The default configuration of a pin is often with a value in the
> pull-up/down field at chip reset. So, even if the internal logic of the
> controller prevents writing a configuration with pull-up and pull-down at
> the same time, we must ensure explicitly this condition before writing the
> register.
>
> This was leading to a pull-down condition not taken into account for
> instance.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxx>
> Fixes: 776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
> Cc: stable@xxxxxxxxxxxxxxx #v4.4 and later
Patch applied for fixes with the ACKs.
Yours,
Linus Walleij