Re: [PATCH v2 1/2][UPDATE] PM / OPP: add non-OF versions of dev_pm_opp_{cpumask_,}remove_table

From: Viresh Kumar
Date: Fri Apr 29 2016 - 05:28:35 EST


This isn't V2, but V3

On 29-04-16, 10:22, Sudeep Holla wrote:
> Functions dev_pm_opp_of_{cpumask_,}remove_table removes/frees all the
> static OPP entries associated with the device and/or all cpus(in case
> of cpumask) that are created from DT.
>
> However the OPP entries are populated reading from the firmware or some
> different method using dev_pm_opp_add are marked dynamic and can't be
> removed using above functions.
>
> This patch adds non DT/OF versions of dev_pm_opp_{cpumask_,}remove_table
> to support the above mentioned usecase.
>
> This is in preparation to make use of the same in scpi-cpufreq.c
>
> Cc: Viresh Kumar <vireshk@xxxxxxxxxx>
> Cc: Nishanth Menon <nm@xxxxxx>
> CC: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> ---
> drivers/base/power/opp/core.c | 56 ++++++++++++++++++++++++++++++----------
> drivers/base/power/opp/cpu.c | 59 ++++++++++++++++++++++++++++++++-----------
> include/linux/pm_opp.h | 10 ++++++++
> 3 files changed, 96 insertions(+), 29 deletions(-)
>
> v1->v2:
> - Instead of renaming OF versions, created non-OF versions of
> dev_pm_opp_{cpumask_,}remove_table as suggested by Viresh
>

You should have added v2->v3 here

> This version also updates all the errors in documentation and changes
> to use remove_all rather than remove_dyn.

But all that isn't going to be part of the history, so it should be fine :)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh