Re: [PATCH v2 1/2][UPDATE] PM / OPP: add non-OF versions of dev_pm_opp_{cpumask_,}remove_table
From: Viresh Kumar
Date: Fri Apr 29 2016 - 05:32:34 EST
On 29-04-16, 10:31, Sudeep Holla wrote:
>
>
> On 29/04/16 10:28, Viresh Kumar wrote:
> >This isn't V2, but V3
> >
> >On 29-04-16, 10:22, Sudeep Holla wrote:
> >>Functions dev_pm_opp_of_{cpumask_,}remove_table removes/frees all the
> >>static OPP entries associated with the device and/or all cpus(in case
> >>of cpumask) that are created from DT.
> >>
> >>However the OPP entries are populated reading from the firmware or some
> >>different method using dev_pm_opp_add are marked dynamic and can't be
> >>removed using above functions.
> >>
> >>This patch adds non DT/OF versions of dev_pm_opp_{cpumask_,}remove_table
> >>to support the above mentioned usecase.
> >>
> >>This is in preparation to make use of the same in scpi-cpufreq.c
> >>
> >>Cc: Viresh Kumar <vireshk@xxxxxxxxxx>
> >>Cc: Nishanth Menon <nm@xxxxxx>
> >>CC: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> >>Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> >>Cc: linux-pm@xxxxxxxxxxxxxxx
> >>Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> >>---
> >> drivers/base/power/opp/core.c | 56 ++++++++++++++++++++++++++++++----------
> >> drivers/base/power/opp/cpu.c | 59 ++++++++++++++++++++++++++++++++-----------
> >> include/linux/pm_opp.h | 10 ++++++++
> >> 3 files changed, 96 insertions(+), 29 deletions(-)
> >>
> >>v1->v2:
> >> - Instead of renaming OF versions, created non-OF versions of
> >> dev_pm_opp_{cpumask_,}remove_table as suggested by Viresh
> >>
> >
> >You should have added v2->v3 here
> >
>
> No, thought I will post v3 of both the patches with your ACK so that
> it's easy for Rafael to pick up if he has no comments :)
Whatever you do, this was v3 unquestionably.
--
viresh