Re: [PATCH 2/6] x86/boot: Move compressed kernel to end of decompression buffer

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> * Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> 
> > I don't agree. We do still have embedded systems running x86 kernels, and we 
> > have cases where we're running multiple kernels in memory (like kdump). I think 
> > the memory savings is worth the complexity, especially since the complexity is 
> > being reduced up by this patch. [...]
> 
> Hm, so can we quantify it, how much are the temporary memory savings in practice? 
> I'd like to see actual vmlinuz numbers with say a defconfig and with a distro 
> config.

Btw., with the extra explanations added to the changelog I am happy with the 
series and have applied it to x86/boot and pushed it out. If we decide to simplify 
the code it will be much easier to simplify correctly working, well documented 
code.

It would be nice to do another pass at the in-code comments and at the general 
code structure, to make sure all this is properly explained and structured.

Thanks,

	Ingo