Re: [PATCH perf/core v5 00/15] perf-probe --cache and SDT support

[Hemant Kumar]

Hi Masami,

On 04/28/2016 12:07 AM, Masami Hiramatsu wrote:
> Hi,
>
> Here is the 5th version of the patchset for probe-cache and
> initial SDT support which are going to be perf-cache finally.
>
> The previous version is here; https://lkml.org/lkml/2016/4/26/179
>
> This version fixes a build bug on "make build-test", removed
> accepted patches, and fold buildid-cache style change and backward
> compatibility patches.
> IOW, just a cleanup version :)
>
> TODOs are here, but I think it should involve kernel-side change
> to complete.
>   - (perf record) Support SDT event recording directly
>   - (perf record) Support @FILE/@BUILDID suffix to record specific SDTs.
>   - (perf record) Try to unregister SDT events after record.

I just sent a patch enabling direct recording on SDT events implementing
1st and 3rd TODOs of the above list. Its based on your patches. Let me
know your thoughts on the same.

--
Thanks,
Hemant Kumar


>   - (ftrace) Support multiple SDTs on single event.
>
> Thank you,
>
> ---
>
> Hemant Kumar (1):
>        perf/sdt: ELF support for SDT
>
> Masami Hiramatsu (14):
>        perf probe: Use strbuf for making strings
>        perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid
>        perf-buildid-cache: Use lsdir for looking up buildid caches
>        perf probe: Add --cache option to cache the probe definitions
>        perf probe: Use cache entry if possible
>        perf probe: Show all cached probes
>        perf probe: Remove caches when --cache is given
>        perf probe: Add group name support
>        perf buildid-cache: Scan and import user SDT events to probe cache
>        perf probe: Accept %sdt and %cached event name
>        perf-list: Show SDT and pre-cached events
>        perf-list: Skip SDTs placed in invalid binaries
>        perf probe: Allow wildcard for cached events
>        perf probe: Support @BUILDID or @FILE suffix for SDT events
>
>
>   tools/perf/Documentation/perf-probe.txt |   24 +
>   tools/perf/builtin-list.c               |    4
>   tools/perf/builtin-probe.c              |   30 +
>   tools/perf/util/build-id.c              |  278 ++++++++++---
>   tools/perf/util/build-id.h              |    6
>   tools/perf/util/dso.h                   |    5
>   tools/perf/util/parse-events.c          |   83 ++++
>   tools/perf/util/parse-events.h          |    2
>   tools/perf/util/probe-event.c           |  684 ++++++++++++++++++++++---------
>   tools/perf/util/probe-event.h           |    9
>   tools/perf/util/probe-file.c            |  492 ++++++++++++++++++++++
>   tools/perf/util/probe-file.h            |   41 ++
>   tools/perf/util/probe-finder.c          |   14 -
>   tools/perf/util/symbol-elf.c            |  252 +++++++++++
>   tools/perf/util/symbol.c                |   15 -
>   tools/perf/util/symbol.h                |   22 +
>   16 files changed, 1689 insertions(+), 272 deletions(-)
>
> --
> Masami Hiramatsu