Re: [PATCH] mtd: nand: gpmi: get correct free oob space

[Han Xu]

________________________________________
From: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
Sent: Friday, April 29, 2016 2:31 AM
To: Han Xu
Cc: richard@xxxxxx; dwmw2@xxxxxxxxxxxxx; computersforpeace@xxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] mtd: nand: gpmi: get correct free oob space

Hi Han,

On Wed, 13 Apr 2016 00:43:51 +0200
Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote:

> Hi Han,
>
> On Tue, 12 Apr 2016 17:06:33 -0500
> Han Xu <han.xu@xxxxxxx> wrote:
>
> > change the way to calculate pagesize to get correct free oob space for
> > legacy_set_geometry function.
>
> Are you sure it's safe to expose free OOB bytes in this case? Do you
> know why it wasn't done before?

You did not answer this question. Do you want me to drop this patch. If
that's not the case, can you confirm it does not break platforms that
didn't have those free OOB bytes exposed before this change.

I think it's safe to expose the free OOB and also tested on my side, no
issue found.

Thanks,

Boris


--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com