Re: [PATCH] sched/core: don't include asm/mmu_context from drivers

From: Andy Lutomirski
Date: Fri Apr 29 2016 - 14:53:01 EST


On Fri, Apr 29, 2016 at 8:37 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Friday 29 April 2016 09:42:18 Steven Rostedt wrote:
>> On Fri, 29 Apr 2016 10:52:32 +0200
>> Arnd Bergmann <arnd@xxxxxxxx> wrote:
>>
>> > This reverts the earlier fix attempt and works around the problem
>> > by including both linux/mmu_context.h and asm/mmu_context.h from
>> > kernel/sched/core.c. This is not a good solution but seems less
>> > hacky than the alternatives.
>>
>> What about simply not compiling finish_arch_post_lock_switch() when
>> building modules?
>>
>> (untested, not compiled or anything)
>>
>> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>>
>
> It should work as well.
>
> I think I suggested doing that the last time the problem came up
> a few years ago, but we ended up not including the header instead,
> so I kept doing that.
>
> Arnd

This variant looks considerably nicer to me.

--Andy