Re: [PATCH V11 6/6] gpio: max77620: add gpio driver for MAX77620/MAX20024

[Laxman Dewangan]

On Saturday 30 April 2016 05:08 PM, Linus Walleij wrote:
> On Thu, Apr 28, 2016 at 11:59 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
>
> > MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
> > pins. It also supports interrupts from these pins.
> >
> > Add GPIO driver for these pins to control via GPIO APIs.
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Gnah there is still a problem with this, I just saw it:
>
> > +config GPIO_MAX77620
> > +       bool "GPIO support for PMIC MAX77620 and MAX20024"
> bool == not a module

Yaah, looked the changes from Gortmaker.
The things are evolving faster.

I think we can change "bool" to "tristate" here.
Then there is no need to have code change. MFD driver is already said as 
tristate.


I will wait for Lee's comment on this series patch before recycling the 
patch. (Already on V11 :-(  ).