Re: [PATCH v3] serial: samsung: Reorder the sequence of clock control when call s3c24xx_serial_set_termios()

From: Krzysztof Kozlowski
Date: Mon May 02 2016 - 08:04:52 EST


On Thu, Apr 21, 2016 at 11:58 AM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
> This patch fixes the broken serial log when changing the clock source
> of uart device. Before disabling the original clock source, this patch
> enables the new clock source to protect the clock off state for a split second.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Reviewed-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> ---
> Changes from v2:
> - Add reviewd-by tag from Marek Szyprowski
> - No changes about operation
>
> Changes from v1:
> - Enable the clock before changing the source by s3c24xx_serial_setsource()
> - Rebase it on Linux v4.6-rc1
>
> drivers/tty/serial/samsung.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Fixes synchronous abort on our Exynos5433-based board. This should be
marked for cc-stable. I'll send a port for that.

BR,
Krzysztof